Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDTCORDirectorySizeTracker: fix NSURL constructor #6580

Merged
merged 4 commits into from
Sep 28, 2020

Conversation

maksymmalyhin
Copy link
Contributor

Fixes #6540

  • replace URLWithString: with fileURLWithPath (the later one was originally supposed to be used). URLWithString: fails to create a URL for paths that contain symbols like a whitespace which is a valid path symbol.

@maksymmalyhin maksymmalyhin added this to the 6.34.0 - M81 milestone Sep 28, 2020
@maksymmalyhin maksymmalyhin merged commit 38be2cc into master Sep 28, 2020
christibbs pushed a commit that referenced this pull request Sep 28, 2020
* GDTCORDirectorySizeTracker: replace optional NSURL constructor with non-optional.

* GDTCORDirectorySizeTracker tests for the issue

* ./scripts/style.sh

* changelog
@firebase firebase locked and limited conversation to collaborators Oct 29, 2020
@paulb777 paulb777 deleted the mm/gdt-file-url branch January 10, 2021 00:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GDTCORDirectorySizeTracker causing a crash
5 participants