Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check_imports check #6640

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Update check_imports check #6640

merged 1 commit into from
Oct 2, 2020

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Oct 1, 2020

Generates check error for an issue discovered in GDT in #6638

#no-changelog

@google-cla google-cla bot added the cla: yes label Oct 1, 2020
@google-oss-bot
Copy link

Danger has errored

[!] Invalid Dangerfile file: syntax error, unexpected tCONSTANT, expecting )
...= hasChangesIn("FirebaseStorage/")
... ^~~~~~~~~~~~~~~
Dangerfile:109: syntax error, unexpected tCONSTANT, expecting end-of-input
...= hasChangesIn("FirebaseStorage/Sources/Public/")
... ^~~~~~~~~~~~~~~. Updating the Danger gem might fix the issue. Your Danger version: 6.1.0, latest Danger version: 8.0.5

 #  from Dangerfile:108
 #  -------------------------------------------
 #  @has_segmentation_api_changes = hasChangesIn("FirebaseSegmentation/Source/Public/
 >  @has_storage_changes = hasChangesIn("FirebaseStorage/")
 #  @has_storage_api_changes = hasChangesIn("FirebaseStorage/Sources/Public/")
 #  -------------------------------------------

Generated by 🚫 Danger

@paulb777 paulb777 merged commit 4afbdba into master Oct 2, 2020
@paulb777 paulb777 deleted the pb-update-check-imports branch October 2, 2020 00:57
@firebase firebase locked and limited conversation to collaborators Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants