Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing iid handler checking cause crash #6737

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Missing iid handler checking cause crash #6737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
952ec71
missing handler checking cause crash
charlotteliang Oct 15, 2020
b45494f
changelog should be in IID not messaging
charlotteliang Oct 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Firebase/InstanceID/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Unreleased -- 7.0.0
- [changed] Deprecated private `-[FIRInstanceID appInstanceID:]` method was removed. (#4486)
- [fixed] Fixed an issue that APNS token is not sent in token request when there's a delay of getting the APNS token from Apple. (#6553)

# 2020-09 -- 4.7.0
- [deprecated] Deprecated InstanceID. For app instance identity handling, use FirebaseInstallations. For FCM registration token handling, use FirebaseMessaging. (#6585)
Expand Down
4 changes: 3 additions & 1 deletion Firebase/InstanceID/FIRInstanceIDTokenManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,9 @@ - (void)fetchNewTokenWithAuthorizedEntity:(NSString *)authorizedEntity
NSError *_Nullable error) {
FIRInstanceID_STRONGIFY(self);
if (error) {
handler(nil, error);
if (handler) {
handler(nil, error);
}
return;
}
NSString *firebaseAppID = options[kFIRInstanceIDTokenOptionsFirebaseAppIDKey];
Expand Down
1 change: 0 additions & 1 deletion FirebaseMessaging/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
- [changed] Remove the deprecated FCM direct channel API and Upstream send API. (#6430)
- [changed] The `messaging:didReceiveRegistrationToken:` should be able to return a null token. Update the API parameter fcmToken to be nullable. (#5339)
- [fixed] Fixed an issue that downloading an image failed when there's no extension in the file name but MIME type is set. (#6590)
- [fixed] Fixed an issue that APNS token is not sent in token request when there's a delay of getting the APNS token from Apple. (#6553)

# 2020-09 -- v.4.7.1
- [added] InstanceID is deprecated, add macro to suppress deprecation warning. (#6585)
Expand Down