Skip loading invalid targets #7018
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt/skiptargets
branch
from
a5457f3
to
b8d000e
Compare
wilhuff
reviewed
Nov 24, 2020
| // In https://github.com/firebase/firebase-ios-sdk/issues/6721, a customer | ||
| // reports that their client crashes with an invalid Target proto. Instead | ||
| // of crashing the client, we skip the target during LRU GC. | ||
| // TODO: Evaluate whether it makes sense to proceed if we can determine |
There was a problem hiding this comment.
Use TODO(username) or TODO(bug) to give context.
A way to achieve the stated goal would be to just avoid the call to decoding the target altogether. If the message fails to even parse, we could synthesize a message with an invalid sequence number that the caller could know to delete. That's probably a bigger change than you want to undertake for this specific fix, so feel free to avoid overhauling this interface for now.
There was a problem hiding this comment.
FWIW I will try to fix these targets in a separate PR now.
var-const
approved these changes
Nov 24, 2020
|
Closing in favor of #7018 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a crash during LRU by simply ignoring targets that cannot be deserialized. We could possibly be smarter about this as we only need the Target ID and the LastListenSequenceNumber to determine what targets to delete, but this for now is the more targeted fix.
Fix: #6721