Update to namespaced GoogleUtilities #7409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksymmalyhin
approved these changes
Jan 29, 2021
Generated by 🚫 Danger |
|
Planning to ignore the clang-format failures since they're from the GHA clang-format version update after we cut this release branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7405
Initially run tests with "test" tags in GoogleUtilities and GoogleAppMeasurement repos before updating their versions.
If tests pass, planning to push to release-7.5 branch and tag a 7.5.1 release just for SPM distro.
See also google/GoogleUtilities#7 and google/GoogleAppMeasurement#3