Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase expectation timeout to 25 seconds. #744

Merged
merged 1 commit into from
Feb 2, 2018
Merged

Increase expectation timeout to 25 seconds. #744

merged 1 commit into from
Feb 2, 2018

Commits on Feb 2, 2018

  1. Increase expectation timeout to 25 seconds. 

    I'm doing this to:
1) Experimentally see if it improves the flakiness we've been seeing in the Query Conformance Tests.
2) Insulate us from the fact that GRPC seems to take a /minimum/ of 10 seconds to reconnect (at least in some cases) after a connection failure.

I've opened b/72864027 to revisit this in the future.
    Michael Lehenbauer committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    1411fa1 View commit details
    Browse the repository at this point in the history