Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecation message for Firestore. #758

Merged
merged 3 commits into from
Feb 8, 2018
Merged

Update deprecation message for Firestore. #758

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93bfd5e
Update FIRFirestore.h
ryanwilson Feb 6, 2018
bc64861
Fixed style of change.
ryanwilson Feb 7, 2018
ea43862
Provide full command to enable debugging.
ryanwilson Feb 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Firestore/Source/Public/FIRFirestore.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ NS_SWIFT_NAME(Firestore)

/** Enables or disables logging from the Firestore client. */
+ (void)enableLogging:(BOOL)logging
DEPRECATED_MSG_ATTRIBUTE("Use FIRSetLoggerLevel(FIRLoggerLevelDebug) to enable logging");
DEPRECATED_MSG_ATTRIBUTE("Use FirebaseConfiguration.shared.setLoggerLevel(_:) to set the "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an effort to let people just copy/paste, can you do FirebaseConfiguration.shared.setLoggerLevel(.debug) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, should I change the text to, "to enable logging" as well instead of "to set the appropriate logging level"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that would be my preference. :-)

"appropriate logging level.");

#pragma mark - Network

Expand Down