Auth integration with App Multicast Delegate #8422
Conversation
…os-sdk into mm/auth-app-delegate
Generated by 🚫 Danger |
| @@ -77,7 +77,14 @@ | |||
| #import "FirebaseAuth/Sources/SystemService/FIRAuthAppCredentialManager.h" | |||
| #import "FirebaseAuth/Sources/SystemService/FIRAuthNotificationManager.h" | |||
| #import "FirebaseAuth/Sources/Utilities/FIRAuthURLPresenter.h" | |||
| #endif | |||
|
|
|||
| #if SWIFT_PACKAGE | |||
There was a problem hiding this comment.
Structure public headers as documented in https://github.com/firebase/firebase-ios-sdk/blob/master/HeadersImports.md#header-file-types-and-locations---for-header-file-creators to avoid need for SPM/CocoaPods specific imports.
There was a problem hiding this comment.
Hm, not sure I understand how it's applicable here because there are no headers in the lib currently, but only a single Swift file. But probably it won't be relevant any more after google/GoogleUtilities#50 (comment) since we will have to re-implement the multicast delegate in Objective-C.
There was a problem hiding this comment.
Oh right. I made this comment before I saw the implementation was Swift.
There was a problem hiding this comment.
TODO: Validate in Firebase
| @@ -153,7 +153,7 @@ let package = Package( | |||
| .package( | |||
| name: "GoogleUtilities", | |||
| url: "https://github.com/google/GoogleUtilities.git", | |||
| "7.4.0" ..< "8.0.0" | |||
| .branch("mm/app-delegate-sample") | |||
There was a problem hiding this comment.
This should not merge to master.
| @@ -482,7 +489,14 @@ - (nullable instancetype)initWithAPIKey:(NSString *)APIKey appName:(NSString *)a | |||
| } | |||
| UIApplication *application = [applicationClass sharedApplication]; | |||
|
|
|||
| [GULAppDelegateSwizzler proxyOriginalDelegateIncludingAPNSMethods]; | |||
| // Use Multicast App Delegate when available but fallback to App Delegate Swizzler for backward compatibility. | |||
| id<GULMulticastAppDelegateProtocol> multicastDelegate = | |||
There was a problem hiding this comment.
Why is this in iOS specific code?
There was a problem hiding this comment.
My guess is it's due to phone auth not being available on other platforms, but that was out of ease-of-implementation not any product decisions.
| id<GULMulticastAppDelegateProtocol> multicastDelegate = | ||
| [GULMulticastAppDelegate installedMulticastDelegate]; | ||
| if (multicastDelegate == nil) { | ||
| FIRLogInfo(kFIRLoggerAuth, @"I-AUT000018", @"Multicast App delegate was not detected. Make sure app events forwarding is configured manually for you app. <Add link to docs>"); |
|
Closing since we no longer plan to do the multicast delegate |
b/193554796