Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists.txt: add -DPB_NO_PACKED_STRUCTS=1 to the nanopb compiler flags #8923

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Nov 3, 2021

This fixes a flurry of "ld: warning: pointer not aligned at address" warnings that reportedly fail the build of the C++ SDK.

Here are some customer reports of these warnings affecting builds:

@google-oss-bot
Copy link

Coverage Report

Affected SDKs

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    SDK overall coverage changed from 87.70% (04b7555) to 87.68% (8aedfa2) by -0.02%.

    Filename Base (04b7555) Head (8aedfa2) Diff
    leveldb_key.cc 96.75% 97.37% +0.62%
    ordered_code.cc 92.18% 91.16% -1.02%
    serializer.cc 87.65% 87.11% -0.54%
    task.cc 93.04% 94.78% +1.74%
    watch_stream.cc 95.35% 90.70% -4.65%

Test Logs

@dconeybe dconeybe merged commit 9d998a7 into master Nov 3, 2021
@dconeybe dconeybe deleted the dconeybe/NanopbNoPackedStructsCmakeFix branch November 3, 2021 17:25
dconeybe added a commit to firebase/firebase-cpp-sdk that referenced this pull request Nov 5, 2021
…at the moment, since firebase/firebase-ios-sdk#8923 has been merged and its branch has been deleted.
@firebase firebase locked and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants