Port Functions integration tests to Swift #8957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
maksymmalyhin
approved these changes
Nov 11, 2021
FirebaseFunctions/Tests/SwiftIntegration/IntegrationTests.swift
Outdated
Show resolved
Hide resolved
FirebaseFunctions/Tests/SwiftIntegration/IntegrationTests.swift
Outdated
Show resolved
Hide resolved
FirebaseFunctions/Tests/SwiftIntegration/IntegrationTests.swift
Outdated
Show resolved
Hide resolved
paulb777
commented
Nov 11, 2021
FirebaseFunctions/Tests/SwiftIntegration/IntegrationTests.swift
Outdated
Show resolved
Hide resolved
FirebaseFunctions/Tests/SwiftIntegration/IntegrationTests.swift
Outdated
Show resolved
Hide resolved
ncooke3
reviewed
Nov 11, 2021
Comment on lines
+153
to
+161
| do { | ||
| XCTAssertNotNil(error) | ||
| let error = try XCTUnwrap(error) as NSError | ||
| XCTAssertEqual(FunctionsErrorCode.internal.rawValue, error.code) | ||
| XCTAssertEqual("Response is missing data field.", error.localizedDescription) | ||
| expectation.fulfill() | ||
| } catch { | ||
| XCTAssert(false, "Failed to unwrap the function result: \(error)") | ||
| } |
There was a problem hiding this comment.
LGTM. You can avoid the do {} catch {} blocks by adding throws to the test method signature. If the XCTUnwrap fails, it'll highlight the line with the failing unwrap.
There was a problem hiding this comment.
I don't think it will work if XCTUnwrap is used inside of the closure.
There was a problem hiding this comment.
Right @maksymmalyhin That's what I found:
There was a problem hiding this comment.
Oh, never thought about that. Makes sense, thanks for pointing that out y'all!
This was referenced Nov 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initfunction not bridging to Swift because of its parameters using forward declarations and to use the existing Objective C fake implementationsFuture PRs will: