Skip to content

Commit

Permalink
Enable previously failing `(Firestore) Node.js and Browser (Chrome) T…
Browse files Browse the repository at this point in the history
…ests` (#8067)

A Firestore CI test configuration was previously disabled in our GitHub action Workflows due to a 100% failure rate. While revisiting this issue months later, it seems that the test now passes. This might be related to our Node v20 CI upgrade.

As a bonus, fixed a comment typo in the check changeset script.
  • Loading branch information
DellaBitta committed Mar 14, 2024
1 parent 1eb302f commit 1494c4b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/test-all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,6 @@ jobs:
name: (Firestore) Node.js and Browser (Chrome) Tests
needs: build
runs-on: ubuntu-latest
if: false
# Disable test for now since it's failing 100% of the time since
# https://github.com/firebase/firebase-js-sdk/pull/7453 and it needs to be investigated.
steps:
# install Chrome so the correct version of webdriver can be installed by chromedriver when setting up the repo
- name: install Chrome stable
Expand Down
2 changes: 1 addition & 1 deletion scripts/ci/check_changeset.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const bumpRank: Record<string, number> = {

/**
* Get highest bump that isn't the main firebase package, return
// numerical rank, bump text, package name.
* numerical rank, bump text, package name.
*/
function getHighestBump(changesetPackages: Record<string, string>) {
const firebasePkgJson = require(resolve(
Expand Down

0 comments on commit 1494c4b

Please sign in to comment.