Merge master into release

.changeset/heavy-starfishes-count.md

@@ -0,0 +1,6 @@
+---
+"@firebase/firestore-compat": feat
+"@firebase/firestore": feat
+---
+
+Relaxing query validation performed by the SDK

.changeset/large-lemons-relax.md

@@ -0,0 +1,6 @@
+---
+'@firebase/firestore': patch
+'firebase': patch
+---
+
+Internal refactor of platform-specific logic to create TextEncoder and TextDecoder objects.

.changeset/perfect-colts-scream.md

@@ -0,0 +1,5 @@
+---
+"@firebase/database-compat": patch
+---
+
+Solve @firebase/database-compat/standalone resolution issues with astrojs

.changeset/popular-apples-peel.md

@@ -0,0 +1,7 @@
+---
+'@firebase/firestore': patch
+'@firebase/util': patch
+'firebase': patch
+---
+
+Modify base64 decoding logic to throw on invalid input, rather than silently truncating it.

.changeset/popular-items-hide.md

@@ -0,0 +1,5 @@
+---
+"@firebase/firestore": patch
+---
+
+Refactoring the aggregation implementation to support future aggregate functions.

.changeset/soft-nails-give.md

@@ -0,0 +1,5 @@
+---
+"@firebase/firestore": patch
+---
+
+Fix unimplemented error when loading bundles

.changeset/tough-taxis-travel.md

@@ -0,0 +1,5 @@
+---
+'@firebase/auth': patch
+---
+
+Modify \_fail to use AuthErrorCode.INTERNAL_ERROR and pass in error message.

.github/CODEOWNERS

@@ -59,10 +59,10 @@ packages/messaging-interop-types @zwu52 @firebase/jssdk-global-approvers
 integration/messaging @zwu52 @firebase/jssdk-global-approvers
 
 # Auth Code
-packages/auth  @avolkovi @lisajian @sam-gc @yuchenshi @firebase/jssdk-global-approvers
-packages/auth-compat @avolkovi @lisajian @sam-gc @yuchenshi @firebase/jssdk-global-approvers
-packages/auth-types @avolkovi @lisajian @sam-gc @yuchenshi @firebase/jssdk-global-approvers
-packages/auth-interop-types @avolkovi @lisajian @sam-gc @yuchenshi @firebase/jssdk-global-approvers
+packages/auth @lisajian @prameshj @renkelvin @sam-gc @firebase/jssdk-global-approvers
+packages/auth-compat @lisajian @prameshj @renkelvin @sam-gc @firebase/jssdk-global-approvers
+packages/auth-types @lisajian @prameshj @renkelvin @sam-gc @firebase/jssdk-global-approvers
+packages/auth-interop-types @lisajian @prameshj @renkelvin @sam-gc @firebase/jssdk-global-approvers
 
 # Testing Code
 packages/rules-unit-testing  @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
@@ -96,6 +96,7 @@ packages/app-check-interop-types @hsubox76 @firebase/jssdk-global-approvers
 # Documentation Changes
 packages/firebase/index.d.ts @egilmorez @firebase/jssdk-global-approvers
 scripts/docgen/content-sources/ @egilmorez @firebase/jssdk-global-approvers
+docs-devsite/ @egilmorez @markarndt
 
 # Changeset
-.changeset @egilmorez @firebase/jssdk-changeset-approvers @firebase/firestore-js-team @firebase/jssdk-global-approvers
+.changeset @firebase/jssdk-changeset-approvers @firebase/firestore-js-team @firebase/jssdk-global-approvers

.github/workflows/check-docs.yml

@@ -0,0 +1,28 @@
+name: Doc Change Check (Run "yarn docgen devsite" if this fails)
+
+on: pull_request
+
+jobs:
+  doc-check:
+    name: Check if reference docs have changed
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: Checkout Repo
+      uses: actions/checkout@master
+      with:
+        # get all history for the diff
+        fetch-depth: 0
+    - name: Set up Node (14)
+      uses: actions/setup-node@v2
+      with:
+        node-version: 14.x
+    - name: Yarn install
+      run: yarn
+    - name: Run doc generation (devsite docs)
+      run: yarn docgen devsite
+    - name: Check for changes in docs-devsite dir (fail if so)
+      run: git diff --exit-code docs-devsite
+    - name: Reference documentation needs to be updated. See message below.
+      if: ${{ failure() }}
+      run: echo "Changes in this PR affect the reference docs. Run \`yarn docgen devsite\` locally to regenerate docs and add them to this PR."

.github/workflows/e2e-test.yml

@@ -47,6 +47,10 @@ jobs:
         working-directory: ./config
         env:
           FIREBASE_CLI_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}
+      - name: Do modular build
+        run: yarn build:modular
+      - name: Do compat build
+        run: yarn build:compat
       - name: Run modular tests
         env:
           APP_CHECK_DEBUG_TOKEN: ${{ secrets.APP_CHECK_DEBUG_TOKEN }}

.gitignore

@@ -89,6 +89,6 @@ packages/**/docs
 tsdoc-metadata.json
 
 # generated html docs
-docs-*/
+docs-rut/
 docs/
 toc/

.vscode/launch.json

@@ -73,8 +73,7 @@
         "--exit"
       ],
       "env": {
-        "FIRESTORE_EMULATOR_PORT" : "8080",
-        "FIRESTORE_EMULATOR_PROJECT_ID" :  "test-emulator"
+        "FIRESTORE_TARGET_BACKEND" : "emulator",
       },
       "sourceMaps": true,
       "protocol": "inspector"
@@ -95,8 +94,7 @@
       ],
       "env": {
         "USE_MOCK_PERSISTENCE": "YES",
-        "FIRESTORE_EMULATOR_PORT" : "8080",
-        "FIRESTORE_EMULATOR_PROJECT_ID" :  "test-emulator"
+        "FIRESTORE_TARGET_BACKEND" : "emulator",
       },
       "sourceMaps": true,
       "protocol": "inspector"

common/api-review/firestore-lite.api.md

@@ -19,11 +19,11 @@ export type AddPrefixToKeys<Prefix extends string, T extends Record<string, unkn
 
 // @public
 export class AggregateField<T> {
-    type: string;
+    readonly type = "AggregateField";
 }
 
 // @public
-export type AggregateFieldType = AggregateField<number>;
+export type AggregateFieldType = AggregateField<number | null>;
 
 // @public
 export class AggregateQuerySnapshot<T extends AggregateSpec> {

common/api-review/firestore.api.md

@@ -19,11 +19,11 @@ export type AddPrefixToKeys<Prefix extends string, T extends Record<string, unkn
 
 // @public
 export class AggregateField<T> {
-    type: string;
+    readonly type = "AggregateField";
 }
 
 // @public
-export type AggregateFieldType = AggregateField<number>;
+export type AggregateFieldType = AggregateField<number | null>;
 
 // @public
 export class AggregateQuerySnapshot<T extends AggregateSpec> {

common/api-review/util.api.md

@@ -93,6 +93,14 @@ export function createSubscribe<T>(executor: Executor<T>, onNoObservers?: Execut
 // @public
 export const decode: (token: string) => DecodedToken;
 
+// Warning: (ae-missing-release-tag) "DecodeBase64StringError" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
+//
+// @public
+export class DecodeBase64StringError extends Error {
+    // (undocumented)
+    readonly name = "DecodeBase64StringError";
+}
+
 // Warning: (ae-missing-release-tag) "deepCopy" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
 //
 // @public

config/functions/package.json

@@ -3,7 +3,7 @@
   "description": "Cloud Functions for Firebase",
   "dependencies": {
     "cors": "2.8.5",
-    "firebase-admin": "11.3.0",
+    "firebase-admin": "11.5.0",
     "firebase-functions": "3.24.1"
   },
   "private": true,

docs-devsite/analytics.analytics.md

@@ -0,0 +1,35 @@
+Project: /docs/reference/js/_project.yaml
+Book: /docs/reference/_book.yaml
+page_type: reference
+
+{% comment %}
+DO NOT EDIT THIS FILE!
+This is generated by the JS SDK team, and any local changes will be
+overwritten. Changes should be made in the source code at
+https://github.com/firebase/firebase-js-sdk
+{% endcomment %}
+
+# Analytics interface
+An instance of Firebase Analytics.
+
+<b>Signature:</b>
+
+```typescript
+export interface Analytics 
+```
+
+## Properties
+
+|  Property | Type | Description |
+|  --- | --- | --- |
+|  [app](./analytics.analytics.md#analyticsapp) | [FirebaseApp](./app.firebaseapp.md#firebaseapp_interface) | The [FirebaseApp](./app.firebaseapp.md#firebaseapp_interface) this [Analytics](./analytics.analytics.md#analytics_interface) instance is associated with. |
+
+## Analytics.app
+
+The [FirebaseApp](./app.firebaseapp.md#firebaseapp_interface) this [Analytics](./analytics.analytics.md#analytics_interface) instance is associated with.
+
+<b>Signature:</b>
+
+```typescript
+app: FirebaseApp;
+```

docs-devsite/analytics.analyticscalloptions.md

@@ -0,0 +1,35 @@
+Project: /docs/reference/js/_project.yaml
+Book: /docs/reference/_book.yaml
+page_type: reference
+
+{% comment %}
+DO NOT EDIT THIS FILE!
+This is generated by the JS SDK team, and any local changes will be
+overwritten. Changes should be made in the source code at
+https://github.com/firebase/firebase-js-sdk
+{% endcomment %}
+
+# AnalyticsCallOptions interface
+Additional options that can be passed to Analytics method calls such as `logEvent`<!-- -->, etc.
+
+<b>Signature:</b>
+
+```typescript
+export interface AnalyticsCallOptions 
+```
+
+## Properties
+
+|  Property | Type | Description |
+|  --- | --- | --- |
+|  [global](./analytics.analyticscalloptions.md#analyticscalloptionsglobal) | boolean | If true, this config or event call applies globally to all Google Analytics properties on the page. |
+
+## AnalyticsCallOptions.global
+
+If true, this config or event call applies globally to all Google Analytics properties on the page.
+
+<b>Signature:</b>
+
+```typescript
+global: boolean;
+```

docs-devsite/analytics.analyticssettings.md

@@ -0,0 +1,35 @@
+Project: /docs/reference/js/_project.yaml
+Book: /docs/reference/_book.yaml
+page_type: reference
+
+{% comment %}
+DO NOT EDIT THIS FILE!
+This is generated by the JS SDK team, and any local changes will be
+overwritten. Changes should be made in the source code at
+https://github.com/firebase/firebase-js-sdk
+{% endcomment %}
+
+# AnalyticsSettings interface
+[Analytics](./analytics.analytics.md#analytics_interface) instance initialization options.
+
+<b>Signature:</b>
+
+```typescript
+export interface AnalyticsSettings 
+```
+
+## Properties
+
+|  Property | Type | Description |
+|  --- | --- | --- |
+|  [config](./analytics.analyticssettings.md#analyticssettingsconfig) | [GtagConfigParams](./analytics.gtagconfigparams.md#gtagconfigparams_interface) \| [EventParams](./analytics.eventparams.md#eventparams_interface) | Params to be passed in the initial <code>gtag</code> config call during Firebase Analytics initialization. |
+
+## AnalyticsSettings.config
+
+Params to be passed in the initial `gtag` config call during Firebase Analytics initialization.
+
+<b>Signature:</b>
+
+```typescript
+config?: GtagConfigParams | EventParams;
+```