Fix internal assertion encountered when testing with jsdom.

firebase · Apr 8, 2024 · 2f58b4f · 2f58b4f
1 parent b64b947
commit 2f58b4f
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/firestore/src/remote/serializer.ts b/packages/firestore/src/remote/serializer.ts
@@ -252,7 +252,7 @@ export function toBytes(
  */
 export function fromBytes(
   serializer: JsonProtoSerializer,
-  value: string | Uint8Array | undefined
+  value: string | Uint8Array | Buffer | undefined
 ): ByteString {
   if (serializer.useProto3Json) {
     hardAssert(
@@ -262,8 +262,10 @@ export function fromBytes(
     return ByteString.fromBase64String(value ? value : '');
   } else {
     hardAssert(
-      value === undefined || value instanceof Uint8Array,
-      'value must be undefined or Uint8Array'
+      value === undefined ||
+        value instanceof Buffer ||
+        value instanceof Uint8Array,
+      'value must be undefined, Buffer, or Uint8Array'
     );
     return ByteString.fromUint8Array(value ? value : new Uint8Array());
   }