Skip to content

Commit

Permalink
Emit a module package file into esm2017 auth webextension bundle (#8191)
Browse files Browse the repository at this point in the history
The Firebase Auth webextension bundle was previously being shipped as a
CommonJS package rather than a ES module, because it did not have a
module package file indicating that it was an ES module.

Fixes #8115
  • Loading branch information
dlarocque committed Apr 23, 2024
1 parent 62a20ff commit 36b283f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/real-ravens-prove.md
@@ -0,0 +1,5 @@
---
'@firebase/auth': patch
---

Emit a module package file with esm2017 auth browser extension builds
3 changes: 2 additions & 1 deletion packages/auth/rollup.config.js
Expand Up @@ -125,7 +125,8 @@ const browserWebExtensionBuilds = [
},
plugins: [
...es2017BuildPlugins,
replace(generateBuildTargetReplaceConfig('esm', 2017))
replace(generateBuildTargetReplaceConfig('esm', 2017)),
emitModulePackageFile()
],
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
},
Expand Down

0 comments on commit 36b283f

Please sign in to comment.