Skip to content

Commit

Permalink
Add @firebase/logger as dependency to app-types (#5144)
Browse files Browse the repository at this point in the history
* Add @firebase/logger as devDependency to app-types

* Change @firebase/logger dependency type to peerDependency

* Pin @firebase/logger version and add as a dependency

* Add changeset
  • Loading branch information
DennisSimon committed Jul 23, 2021
1 parent e72e351 commit 3d10d33
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/short-lies-sing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@firebase/app-types': patch
---

Add @firebase/logger as a dependency to @firebase/app-types to ensure that it can be resolved when compiling the package in a strict yarn PnP environment.
3 changes: 3 additions & 0 deletions packages/app-types/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
"bugs": {
"url": "https://github.com/firebase/firebase-js-sdk/issues"
},
"dependency": {
"@firebase/logger": "0.2.6"
},
"devDependencies": {
"typescript": "4.2.2"
}
Expand Down

0 comments on commit 3d10d33

Please sign in to comment.