Skip to content

Commit

Permalink
fix RTDB build (#4777)
Browse files Browse the repository at this point in the history
* fix rtdb build

* Create hip-dingos-judge.md
  • Loading branch information
Feiyang1 committed Apr 13, 2021
1 parent 726bf68 commit 74fa506
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/hip-dingos-judge.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@firebase/database": patch
---

Fix a build issue that caused SDK breakage.
15 changes: 12 additions & 3 deletions packages/database/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ const es5Builds = [
output: [{ file: pkg.main, format: 'cjs', sourcemap: true }],
plugins: es5BuildPlugins,
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
onwarn: onWarn
onwarn: onWarn,
treeshake: {
moduleSideEffects: false
}
},
/**
* Browser Builds
Expand All @@ -60,7 +63,10 @@ const es5Builds = [
output: [{ file: pkg.module, format: 'es', sourcemap: true }],
plugins: es5BuildPlugins,
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
onwarn: onWarn
onwarn: onWarn,
treeshake: {
moduleSideEffects: false
}
}
];

Expand Down Expand Up @@ -88,7 +94,10 @@ const es2017Builds = [
output: [{ file: pkg.esm2017, format: 'es', sourcemap: true }],
plugins: es2017BuildPlugins,
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
onwarn: onWarn
onwarn: onWarn,
treeshake: {
moduleSideEffects: false
}
}
];

Expand Down

0 comments on commit 74fa506

Please sign in to comment.