Skip to content

Commit

Permalink
[E2E CI] Update firebase-tools to v13.0.2 (#7883)
Browse files Browse the repository at this point in the history
Previously we ran into an issue where we couldn't use the latest firebase-tools CLI version (v13+) due to an error attempting to deploy the E2E cloud function.

The error was due to a new requirement of the CLI that `firebase.json` requires a `functions` configuration. This change adds that configuration and pins the firebase CLI version to 13.0.2.
  • Loading branch information
DellaBitta committed Dec 18, 2023
1 parent 07a65d3 commit ac7fee1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/e2e-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
pushd functions
npm install
popd
npx firebase-tools@12.9.1 deploy --only functions:callTest --project jscore-sandbox-141b5 --token $FIREBASE_CLI_TOKEN
npx firebase-tools@13.0.2 deploy --only functions:callTest --project jscore-sandbox-141b5 --token $FIREBASE_CLI_TOKEN
working-directory: ./config
env:
FIREBASE_CLI_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}
Expand Down
3 changes: 3 additions & 0 deletions config/firebase.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,8 @@
"firestore": {
"rules": "firestore.rules",
"indexes": "firestore.indexes.json"
},
"functions": {
"runtime": "nodejs18"
}
}

0 comments on commit ac7fee1

Please sign in to comment.