reliably update service worker (#2638)

firebase · Feb 18, 2020 · b40d71e · b40d71e
1 parent fde2314
commit b40d71e
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/packages/messaging/src/controllers/window-controller.ts b/packages/messaging/src/controllers/window-controller.ts
@@ -167,6 +167,12 @@ export class WindowController implements FirebaseMessaging, FirebaseService {
             scope: DEFAULT_SW_SCOPE
           }
         );
+
+        // The timing when browser updates sw when sw has an update is unreliable by my experiment. 
+        // It leads to version conflict when the SDK upgrades to a newer version in the main page, but 
+        // sw is stuck with the old version. For example, https://github.com/firebase/firebase-js-sdk/issues/2590
+        // The following line reliably updates sw if there was an update.
+        this.swRegistration.update().catch(() => { /* it is non blocking and we don't care if it failed */ });
       } catch (e) {
         throw ERROR_FACTORY.create(ErrorCode.FAILED_DEFAULT_REGISTRATION, {
           browserErrorMessage: e.message