[Auth] Add tabindex=-1 to iframe to fix issue with aria-hidden (#5700)

* Add tabindex=-1 to iframe to fix issue with aria-hidden * Add changeset
firebase · Nov 4, 2021 · dbd54f7 · dbd54f7
1 parent ee440a8
commit dbd54f7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/witty-kids-buy.md b/.changeset/witty-kids-buy.md
@@ -0,0 +1,5 @@
+---
+"@firebase/auth": patch
+---
+
+Fix lighthouse issues related to the embedded iframe used to perform OAuth sign in.
diff --git a/packages/auth/src/platform_browser/iframe/iframe.test.ts b/packages/auth/src/platform_browser/iframe/iframe.test.ts
@@ -86,6 +86,7 @@ describe('platform_browser/iframe/iframe', () => {
         height: '1px'
       },
       'aria-hidden': 'true',
+      tabindex: '-1'
     });
     expect(iframeSettings.dontclear).to.be.true;
   });

diff --git a/packages/auth/src/platform_browser/iframe/iframe.ts b/packages/auth/src/platform_browser/iframe/iframe.ts
@@ -38,7 +38,8 @@ const IFRAME_ATTRIBUTES = {
     width: '1px',
     height: '1px'
   },
-  'aria-hidden': 'true'
+  'aria-hidden': 'true',
+  tabindex: '-1'
 };
 
 // Map from apiHost to endpoint ID for passing into iframe. In current SDK, apiHost can be set to