Disable nightly run with PR (#7876)

* Disable nightly run with PR * triggers a firestore change * feedback * try again
firebase · Jan 4, 2024 · e5fc290 · e5fc290
1 parent 16728cf
commit e5fc290
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/test-changed-firestore.yml b/.github/workflows/test-changed-firestore.yml
@@ -14,7 +14,9 @@
 
 name: Test Firestore
 
-on: pull_request
+on:
+  workflow_dispatch:
+  pull_request:
 
 env:
   artifactRetentionDays: 14
@@ -138,7 +140,7 @@ jobs:
         test-name: ["test:browser:nightly"]
     runs-on: ubuntu-latest
     needs: build
-    if: ${{ needs.build.outputs.changed == 'true'}}
+    if: ${{ github.event_name != 'pull_request' }}
     steps:
       - name: Set up Node (16)
         uses: actions/setup-node@v3

diff --git a/packages/firestore/test/integration/api/query.test.ts b/packages/firestore/test/integration/api/query.test.ts
@@ -411,7 +411,7 @@ apiDescribe('Queries', persistence => {
     });
   });
 
-  it('maintains correct DocumentChange indices', async () => {
+  it('maintains correct DocumentChange indexes', async () => {
     const testDocs = {
       'a': { order: 1 },
       'b': { order: 2 },