Storage: Do not throw for path containing ".." (#5315)

firebase · Aug 17, 2021 · fbb32e7 · fbb32e7
1 parent d0710d5
commit fbb32e7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/.changeset/big-lobsters-tell.md b/.changeset/big-lobsters-tell.md
@@ -0,0 +1,5 @@
+---
+'@firebase/storage': patch
+---
+
+Change `ref()` to not throw if given a path with '..' in it.
diff --git a/packages/storage/src/service.ts b/packages/storage/src/service.ts
@@ -74,9 +74,6 @@ function refFromPath(
   } else {
     // ref is a Reference
     if (path !== undefined) {
-      if (path.includes('..')) {
-        throw invalidArgument('`path` param cannot contain ".."');
-      }
       return _getChild(ref, path);
     } else {
       return ref;

diff --git a/packages/storage/test/unit/service.exp.test.ts b/packages/storage/test/unit/service.exp.test.ts
@@ -372,12 +372,6 @@ GOOG4-RSA-SHA256`
       const newRef = ref(reference);
       expect(newRef.toString()).to.equal('gs://bucket/object');
     });
-    it('Throws calling ref(reference, path) if path contains ".."', () => {
-      const error = testShared.assertThrows(() => {
-        ref(reference, `../child/path`);
-      }, 'storage/invalid-argument');
-      expect(error.message).to.match(/"\.\."/);
-    });
   });
 
   describe('Deletion', () => {