Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase.SDK_VERSION stuck at 8.0.1 #4235

Closed
lupas opened this issue Dec 22, 2020 · 2 comments · Fixed by #4283 or #4941
Closed

Firebase.SDK_VERSION stuck at 8.0.1 #4235

lupas opened this issue Dec 22, 2020 · 2 comments · Fixed by #4283 or #4941
Assignees

Comments

@lupas
Copy link
Contributor

lupas commented Dec 22, 2020

  • Operating System version: Mac OS 11.1
  • Browser version: not applicable
  • Firebase SDK version: 8.2.1
  • Firebase Product: all

Describe the problem

const firebase = require('firebase/app')
console.log(firebase.SDK_VERSION)
// Result: "8.0.1"
// Expected: "8.2.1"

Also see all the .js files in @firebase/app/dist contain the following:

const version$1 = "8.0.1";

Steps to reproduce:

See the two lines above.

Relevant Code:

See the two lines above.

Background

We use the SDK_VERSION in the Firebase module for NuxtJS (https://firebase.nuxtjs.org) to load the appropriate Firebase scripts in the created service-workers (e.g. via 'https://www.gstatic.com/firebasejs/8.0.1/firebase-app.js')

@google-oss-bot
Copy link
Contributor

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@hsubox76
Copy link
Contributor

Thanks for reporting this, it's on our list to fix. It seems like we need to have @firebase/app get the version string dynamically somehow instead of being bundled into its code at compile time, since the @firebase/app package isn't necessarily published with every release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants