Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update SDK_VERSION to the latest value in firebase/app #4283

Merged
merged 2 commits into from
May 25, 2021

Conversation

Feiyang1
Copy link
Member

Fixes #4235

firebase.SDK_VERSION may not be up to date because the value is set at compile time in @firebase/app, which is not necessarily published with every release. This change updates firebase.SDK_VERSION to the latest version of firebase package.

Note that the solution will NOT work if you import scoped packages.
You should import using the umbrella package:

import firebase from 'firebase/app';
firebase.SDK_VERSION; // the latest version

// DON'T do it if you want the latest SDK VERSION
// import firebase from '@firebase/app';
// firebase.SDK_VERSION; // might be a stale version

To fix the issue for the scoped package, we will need to publish @firebase/app with every release to make sure SDK_VERSION is up to date. We need to create a process to automatically add a changeset for @firebase/app for every release.

Since using the umbrella package to import firebase is the recommended way of doing things and all our guides and snippets use the umbrella package, this fix should be sufficient for now and will work for the majority of our users.

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2021

🦋 Changeset detected

Latest commit: f6218af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 13, 2021

Size Analysis Report

Affected Products

No changes between base commit (da7f7ff) and head commit (064a660).

Test Logs

@Feiyang1 Feiyang1 merged commit b49345d into master May 25, 2021
@Feiyang1 Feiyang1 deleted the fei-sdk-version branch May 25, 2021 23:49
@google-oss-bot google-oss-bot mentioned this pull request Jun 2, 2021
@firebase firebase locked and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firebase.SDK_VERSION stuck at 8.0.1
3 participants