Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`Duplicate identifier` errors when compiling a project which links a module #474

Closed
SamVerschueren opened this issue Jan 30, 2018 · 3 comments

Comments

@SamVerschueren
Copy link

commented Jan 30, 2018

Describe your environment

  • Operating System version: macOS Sierra
  • Firebase SDK version: 4.9.0
  • Firebase Product: auth, database

Describe the problem

We are using a monorepo and have a module (A) which depends on another module (B). Both of firebase listed as dependency. Compiling module B is not a problem. Compiling module A however is. These errors are showing up:

screen shot 2018-01-28 at 19 19 31

I tweeted about this, and @DanielRosenwasser replied that it should be fixed in here. https://twitter.com/drosenwasser/status/957872358978609152

I was able to solve it with paths mappings in tsconfig.json, but would be nice if it just worked without.

Steps to reproduce:

  1. Create 2 modules which both have firebase as dependency
  2. Link one module to the other yarn add link:../module-b
  3. Compile

(Better to look at the reproduction repository)

Relevant Code:

Here's the repository I created to reproduce the problem. https://github.com/SamVerschueren/firebase-duplicate-tsd

// @jshcrowthe

@google-oss-bot

This comment has been minimized.

Copy link
Collaborator

commented Jan 30, 2018

Hmmm this issue does not seem to follow the issue template. Make sure you provide all the required information.

@jshcrowthe jshcrowthe self-assigned this Jan 30, 2018

@jshcrowthe jshcrowthe added api: core and removed api: auth labels Jan 30, 2018

@PascalPrecht

This comment has been minimized.

Copy link

commented Mar 28, 2018

I can confirm this issue. This a problem that exists with firebase version 4.9.0+.

@PascalPrecht

This comment has been minimized.

Copy link

commented Apr 3, 2018

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.