Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for lazy registration of app components #15

Merged
merged 9 commits into from May 25, 2017
Merged

Allow for lazy registration of app components #15

merged 9 commits into from May 25, 2017

Commits on May 18, 2017

  1. WIP: add lazy module instantiation

    @jshcrowthe
    jshcrowthe committed May 18, 2017
    Configuration menu
    Copy the full SHA
    718c99c View commit details
    Browse the repository at this point in the history

  2. feat(app): allow for lazy loading of services

    @jshcrowthe
    jshcrowthe committed May 18, 2017
    Configuration menu
    Copy the full SHA
    1413770 View commit details
    Browse the repository at this point in the history

  3. test(app): add integration test for webpack/browserify for lazy insta… 

    …ntiation
    @jshcrowthe
    jshcrowthe committed May 18, 2017
    Configuration menu
    Copy the full SHA
    f26cfc5 View commit details
    Browse the repository at this point in the history

  4. fix(app): fix issue where auth listeners weren't being patched properly

    @jshcrowthe
    jshcrowthe committed May 18, 2017
    Configuration menu
    Copy the full SHA
    3a38558 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2017

  1. docs(app): adding doc explaining Firebase Auth specific code in fireb… 

    …ase_app.ts
    @jshcrowthe
    jshcrowthe committed May 22, 2017
    Configuration menu
    Copy the full SHA
    47d618a View commit details
    Browse the repository at this point in the history

Commits on May 23, 2017

  1. fix(app): revert code refactor to _getService function

    @jshcrowthe
    jshcrowthe committed May 23, 2017
    Configuration menu
    Copy the full SHA
    9baf65f View commit details
    Browse the repository at this point in the history

  2. test(app): add tests and fix issue with multiple instances of a service 

    There was an issue where we weren't properly limiting mulitple service instances. Added a test and
refactored the code to support that use case
    @jshcrowthe
    jshcrowthe committed May 23, 2017
    Configuration menu
    Copy the full SHA
    99820ef View commit details
    Browse the repository at this point in the history

Commits on May 24, 2017

  1. refactor(app): remove unneeded ternary

    @jshcrowthe
    jshcrowthe committed May 24, 2017
    Configuration menu
    Copy the full SHA
    3e211b3 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2017

  1. fix(app): fix issue where instanceIdentifier wasn't being passed 

    Fixed an issue where instance identifiers weren't being passed to their creation factories. Added
some tests to validate that we don't accidentally remove that in the future.
    @jshcrowthe
    jshcrowthe committed May 25, 2017
    Configuration menu
    Copy the full SHA
    c75fb59 View commit details
    Browse the repository at this point in the history