Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treat the ns= query param as the namespace name if it is present #2060

Merged
merged 9 commits into from
Aug 10, 2019
Merged

treat the ns= query param as the namespace name if it is present #2060

merged 9 commits into from
Aug 10, 2019

Conversation

jmwski
Copy link
Contributor

@jmwski jmwski commented Aug 7, 2019

No description provided.

schmidt-sebastian
schmidt-sebastian reviewed Aug 7, 2019
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Since this is a breaking change, we should add a change log entry that calls this out. Do you mind doing this?

I also want your verbal (or rather written) nod that you tested this manually. Thanks.

@jmwski jmwski assigned mikelehen and unassigned jmwski and schmidt-sebastian Aug 8, 2019
mikelehen
mikelehen suggested changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM with a couple suggestions. I also would like Sebastian to look at this again since he did the initial review and he owns the RTDB SDK at this point. :-)

packages/database/src/core/util/libs/parser.ts Show resolved Hide resolved
packages/database/src/core/util/libs/parser.ts Outdated
webSocketOnly
webSocketOnly,
'',
parsedUrl.namespace != parsedUrl.subdomain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using literals or boolean expressions as function arguments, it's often helpful to comment them for the reader, something like:

    webSocketOnly,
    /*persistenceKey=*/ '',
    /*withQueryParam=*/ parsedUrl.namespace != parsedUrl.subdomain

packages/database/src/core/RepoInfo.ts Outdated Show resolved Hide resolved
@schmidt-sebastian schmidt-sebastian removed their assignment Aug 9, 2019
@jmwski jmwski assigned mikelehen and unassigned jmwski Aug 9, 2019
mikelehen
mikelehen approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikelehen mikelehen assigned jmwski and unassigned mikelehen Aug 9, 2019
@jmwski
Copy link
Contributor Author

jmwski commented Aug 9, 2019

Awesome!

Since this is a breaking change, we should add a change log entry that calls this out. Do you mind doing this?

I also want your verbal (or rather written) nod that you tested this manually. Thanks.

I tested this manually.

@jmwski jmwski merged commit e4eea3f into master Aug 10, 2019
@jmwski jmwski deleted the wyszynski/prefer-ns-query-param branch August 10, 2019 01:01
mikelehen pushed a commit that referenced this pull request Aug 12, 2019
@jmwski
treat the ns= query param as the namespace name if it is present (#…
4ed528d 
…2060)

* treat `ns=` query param as the namespace name if it is present

* [AUTOMATED]: Prettier Code Styling

* record ns queryparam override in RepoInfo class

* [AUTOMATED]: Prettier Code Styling

* update database test suite

* more descriptive RepoInfo member name

* Add to changelog
@firebase firebase locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@jsdt jsdt Awaiting requested review from jsdt

Assignees

@jmwski jmwski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmwski @mikelehen @schmidt-sebastian