Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not throw error on duplicate service registration. #2085

Merged
merged 7 commits into from
Aug 16, 2019
Merged

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Aug 15, 2019

A change needed for when multiple components each internally depend on another component and may each try to register it.

packages/app/src/firebaseNamespaceCore.ts Outdated Show resolved Hide resolved
packages/app/test/firebaseApp.test.ts Outdated Show resolved Hide resolved
@hsubox76 hsubox76 merged commit 06bad3e into master Aug 16, 2019
@lookfirst
Copy link

THANK YOU!

@firebase firebase locked and limited conversation to collaborators Oct 8, 2019
@hsubox76 hsubox76 deleted the ch-duplicate branch January 8, 2020 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants