Add optimization to SortedSet.unionWith #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-hui
requested review from
avolkovi,
sam-gc,
scottcrossen and
yuchenshi
as code owners
yuchenshi
approved these changes
Feb 12, 2020
| @@ -134,7 +134,7 @@ function initializeApp( | |||
| ({ | |||
| getToken: async () => ({ accessToken: accessToken }), | |||
| getUid: () => null, | |||
| addAuthTokenListener: (listener) => { | |||
| addAuthTokenListener: listener => { | |||
There was a problem hiding this comment.
I don't see why we need this change, but if it's an auto-formatting or linter thing, then you have my approval.
There was a problem hiding this comment.
Yeah, this is from auto-formatting.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to #2620
Basically
SortedSet.unionWithdoes not take the size of the two sets that it is merging into consideration.What happens is, if there are two set: A that is empty, and B that has size of
N. The union would takeO(N*logN)while it could have been a no-op.