Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable flakey messaging tests (@gauntface to investigate) #281

Merged
merged 1 commit into from Oct 31, 2017
Merged

Temporarily disable flakey messaging tests (@gauntface to investigate) #281

merged 1 commit into from Oct 31, 2017

Conversation

jshcrowthe
Copy link
Contributor

To promote a stable CI env, we are temporarily disabling these tests while @gauntface investigates the root cause of their flakiness.

gauntface
gauntface approved these changes Oct 31, 2017
View reviewed changes
Copy link
Contributor

@gauntface gauntface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as the Karma tests still run.

@jshcrowthe jshcrowthe merged commit a7c71d4 into master Oct 31, 2017
@jshcrowthe jshcrowthe deleted the disable-auth-int branch October 31, 2017 17:59
schmidt-sebastian pushed a commit that referenced this pull request Nov 3, 2017
@jshcrowthe @schmidt-sebastian
Temporarily disable flakey messaging tests (@gauntface to investigate) (
39972a5 
#281)
@firebase firebase locked and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gauntface gauntface gauntface approved these changes

Assignees

@gauntface gauntface

Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jshcrowthe @gauntface @google-oss-bot