Add support for API timeouts to auth-next #2915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avolkovi
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
Binary Size ReportAffected SDKsNo changes between base commit (11dd5ee) and head commit (ef1d48a). Test Logs
|
sam-gc
reviewed
Apr 15, 2020
| @@ -88,7 +92,8 @@ export async function performApiRequest<T, V>( | |||
| } else { | |||
| // TODO probably should handle improperly formatted errors as well | |||
| // If you see this, add an entry to SERVER_ERROR_MAP for the corresponding error | |||
| throw new Error(`Unexpected API error: ${json.error.message}`); | |||
| console.error(`Unexpected API error: ${json.error.message}`); | |||
There was a problem hiding this comment.
I added the console.error since we never expect to see these, it would help in debugging since we mask json.error.message with an error from the map (in this case, internal-error)
Feiyang1
reviewed
Apr 15, 2020
avolkovi
force-pushed
the
avolkovi/auth-next-api-timeout
branch
from
6021352
to
b8e5442
Compare
avolkovi
force-pushed
the
avolkovi/auth-next-api-timeout
branch
from
b8e5442
to
07ac4b2
Compare
avolkovi
added a commit
that referenced
this pull request
Apr 22, 2020
* Add support for API timeouts to auth-next * PR feedback * [AUTOMATED]: Prettier Code Styling
avolkovi
added a commit
that referenced
this pull request
Apr 23, 2020
* Add support for API timeouts to auth-next * PR feedback * [AUTOMATED]: Prettier Code Styling
avolkovi
added a commit
that referenced
this pull request
Apr 24, 2020
* Add support for API timeouts to auth-next * PR feedback * [AUTOMATED]: Prettier Code Styling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.