Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow undefined callbacks in Storage Observer #3224

Merged
merged 3 commits into from
Jul 9, 2020
Merged

Allow undefined callbacks in Storage Observer #3224

merged 3 commits into from
Jul 9, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian mentioned this pull request Jun 16, 2020
Closed
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 16, 2020 •
edited

Binary Size Report

Affected SDKs

No changes between base commit (0b14a8c) and head commit (bcefa7e).

Test Logs

@schmidt-sebastian
Copy link
Contributor Author

schmidt-sebastian commented Jun 16, 2020 •
edited

Note: This requires our users to be on TypeScript 2.1, which might be an existing requirement, but I don't see any other usage of Required, Partial or Optional.

@schmidt-sebastian
Copy link
Contributor Author

@hsubox76 Do you have time to take a look?

hsubox76
hsubox76 approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this.

@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2020 •
edited

🦋 Changeset is good to go

Latest commit: fac6281

We got this.

This PR includes changesets to release 9 packages
Name Type
firebase Patch
@firebase/storage-types Patch
@firebase/storage Patch
@firebase/testing Patch
firebase-browserify-test Patch
firebase-package-typings-test Patch
firebase-messaging-selenium-test Patch
firebase-typescript-test Patch
firebase-webpack-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@schmidt-sebastian schmidt-sebastian merged commit 9c409ea into master Jul 9, 2020
@google-oss-bot google-oss-bot mentioned this pull request Jul 15, 2020
Merged
@Feiyang1 Feiyang1 mentioned this pull request Jul 16, 2020
Merged
@google-oss-bot google-oss-bot mentioned this pull request Jul 16, 2020
Merged
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/storage branch July 17, 2020 01:40
@firebase firebase locked and limited conversation to collaborators Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez egilmorez is a code owner

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firebase storage UploadTask callback type requires all callbacks
3 participants
@schmidt-sebastian @google-oss-bot @hsubox76