Remove makeConstructorPrivate #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 83571d2 We got this. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
Binary Size ReportAffected SDKs
Test Logs
|
…/firebase-js-sdk into mrschmidt/makeconstructorpublic
Feiyang1
approved these changes
Jun 26, 2020
Feiyang1
suggested changes
Jun 26, 2020
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@firebase/firestore": patch | |||
Feiyang1
approved these changes
Jun 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The makeConstructorPrivate pattern is used in the SDK to prevent JS SDK users from constructing our internal types. This pattern is unique to Firestore, but seems to break in subtle and not so subtle ways that we currently cannot catch in CI (due to missing Saucelabs tests). Instead of iterating on this pattern, we decided to remove it altogether, which also adds a little bit of tree-shakeability to our current SKD (but probably only for users of
Blob).Fixes #3305