Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add browser field to auth #3401

Merged
merged 2 commits into from
Jul 15, 2020
Merged

add browser field to auth #3401

merged 2 commits into from
Jul 15, 2020

Conversation

Feiyang1
Copy link
Member

Fixes #3397

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2020 •
edited

🦋 Changeset is good to go

Latest commit: ba55672

We got this.

This PR includes changesets to release 8 packages
Name Type
@firebase/auth Patch
firebase Patch
@firebase/testing Patch
firebase-browserify-test Patch
firebase-package-typings-test Patch
firebase-messaging-selenium-test Patch
firebase-typescript-test Patch
firebase-webpack-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 13, 2020 •
edited

Binary Size Report

Affected SDKs

  • @firebase/auth

    Type Base (b07f822) Head (92b70f9) Diff
    browser ? 177 kB ? (?)

Test Logs

@avolkovi avolkovi removed their assignment Jul 14, 2020
hiranya911
hiranya911 approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Feiyang1 Feiyang1 merged commit b614546 into master Jul 15, 2020
@Feiyang1 Feiyang1 deleted the fei-auth-browser branch July 15, 2020 18:05
This was referenced Jul 15, 2020
Merged
Merged
@firebase firebase locked and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avolkovi avolkovi avolkovi approved these changes

@hiranya911 hiranya911 hiranya911 approved these changes

@bojeil-google bojeil-google Awaiting requested review from bojeil-google

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@scottcrossen scottcrossen Awaiting requested review from scottcrossen

Assignees

@bojeil-google bojeil-google

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to use Firebase-Auth Feature in esm Bundle in Browser
5 participants
@Feiyang1 @google-oss-bot @avolkovi @hiranya911 @bojeil-google