Util version bump #3472
Merged
Util version bump #3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 756f99a We got this. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Feiyang1
reviewed
Jul 24, 2020
.changeset/short-cars-scream.md
Outdated
| @@ -0,0 +1,8 @@ | |||
| --- | |||
| '@firebase/analytics': patch | |||
| '@firebase/util': patch | |||
There was a problem hiding this comment.
util should be minor. Can you also add what new functions are added to util?
Suggested change
| '@firebase/util': patch | |
| '@firebase/util': minor |
There was a problem hiding this comment.
Done, I suppose firebase should be minor as well then?
There was a problem hiding this comment.
no, because it doesn't cause any API change in firebase
Binary Size ReportAffected SDKsNo changes between base commit (18e5dea) and head commit (72770c3). Test Logs
|
Feiyang1
approved these changes
Jul 24, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I approved https://github.com/firebase/firebase-js-sdk/pull/3165/files without realizing that it required a util bump because util code was changed.
I'm not sure if the bump should be minor instead because it added 3 public util methods.
Hope to cherrypick and re-release.