Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in AsyncQueue visibility handler #3586

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

I wanted to add logging for the visibility handler in AsyncQueue, which is good because it made me realize that I attached the visibility handler to the wrong object.

@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2020

🦋 Changeset is good to go

Latest commit: 3670309

We got this.

This PR includes changesets to release 10 packages
Name Type
@firebase/firestore Patch
firebase Patch
firebase-exp Patch
firebase-firestore-integration-test Patch
@firebase/testing Patch
firebase-browserify-test Patch
firebase-package-typings-test Patch
firebase-messaging-selenium-test Patch
firebase-typescript-test Patch
firebase-webpack-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 7, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (41ed6f2) Head (74d84e5) Diff
    browser 249 kB 249 kB +140 B (+0.1%)
    esm2017 195 kB 195 kB +151 B (+0.1%)
    main 475 kB 474 kB -273 B (-0.1%)
    module 247 kB 247 kB +140 B (+0.1%)
    react-native 195 kB 195 kB +151 B (+0.1%)
  • @firebase/firestore/exp

    Type Base (41ed6f2) Head (74d84e5) Diff
    browser 188 kB 188 kB +151 B (+0.1%)
    main 467 kB 467 kB -273 B (-0.1%)
    module 188 kB 188 kB +151 B (+0.1%)
    react-native 188 kB 189 kB +151 B (+0.1%)
  • @firebase/firestore/lite

    Type Base (41ed6f2) Head (74d84e5) Diff
    browser 64.3 kB 64.4 kB +130 B (+0.2%)
    main 142 kB 142 kB -365 B (-0.3%)
    module 64.3 kB 64.4 kB +130 B (+0.2%)
    react-native 64.4 kB 64.5 kB +130 B (+0.2%)
  • @firebase/firestore/memory

    Type Base (41ed6f2) Head (74d84e5) Diff
    browser 187 kB 187 kB +119 B (+0.1%)
    esm2017 146 kB 146 kB +130 B (+0.1%)
    main 349 kB 348 kB -365 B (-0.1%)
    module 185 kB 185 kB +119 B (+0.1%)
    react-native 146 kB 146 kB +130 B (+0.1%)
  • firebase

    Type Base (41ed6f2) Head (74d84e5) Diff
    firebase-firestore.js 288 kB 288 kB +141 B (+0.0%)
    firebase-firestore.memory.js 227 kB 227 kB +120 B (+0.1%)
    firebase.js 821 kB 821 kB +141 B (+0.0%)

Test Logs

Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff Aug 7, 2020
@schmidt-sebastian schmidt-sebastian merged commit 68995c2 into master Aug 10, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/foregroundlogs branch August 10, 2020 19:14
@google-oss-bot google-oss-bot mentioned this pull request Aug 11, 2020
@firebase firebase locked and limited conversation to collaborators Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants