Add environment check to Remote-Config Module #3623
Conversation
🦋 Changeset detectedLatest commit: d11c83d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs
|
packages/remote-config/index.ts
Outdated
| * 2. check if the current browser context is valid for using IndexedDB. | ||
| * | ||
| */ | ||
| async function isSupported(): Promise<boolean> { |
There was a problem hiding this comment.
Thinking (no action req'd): the change to registerRemoteConfig will throw if IndexedDB is unavailable, in which case we'd need a method to call prior to registration, which is why isSupported is static, ie:
import * as remoteconfig from 'firebase/remote-config';
import * as firebase from 'firebase/app';
if (remoteconfig.isSupported()) {
const rc = firebase.remoteconfig();
...
}
Changeset File Check ✅
|
packages/firebase/index.d.ts
Outdated
| @@ -1772,6 +1772,15 @@ declare namespace firebase.remoteConfig { | |||
| * Defines levels of Remote Config logging. | |||
| */ | |||
| export type LogLevel = 'debug' | 'error' | 'silent'; | |||
| /** | |||
| * Returns true if current browser context supports initialization of remote config module | |||
There was a problem hiding this comment.
@egilmorez Can you please take a look at it?
Sorry, this should go away if you pull master now, or you can just ignore it. |
hsubox76
force-pushed
the
issue2393-remote-config
branch
from
f053094
to
d11c83d
Compare
hsubox76
changed the title
|
I've rebased and updated this since it was last updated a year ago. |
Issue 2393 fix for Remote-Config module.
Added
isSupportedmethod where users can call to check if indexedDB is supported before initializing the module.Fixes #5502