Don't switch network status to UNKNOWN during user change #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 72e5195 We got this. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…se/firebase-js-sdk into mrschmidt/credentialchangenetwork
Size Analysis ReportAffected ProductsNo changes between base commit (0dfd516) and head commit (bd90a54). Test Logs
|
dconeybe
approved these changes
Aug 28, 2020
|
@dconeybe I had to change the code because it caused the IndexedDB retry to fail. |
dconeybe
approved these changes
Aug 28, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user change handling on Web resets the OnlineStatus to unknown even if we are offline. This breaks offline behavior for empty snapshots from cache, as we will stop raising empty snapshots.
This fixes a regression in the Web client. The Android and iOS client should have the correct behavior (see Android: https://github.com/firebase/firebase-android-sdk/blob/751684d3073329adef4cbca8865efa22c953fa5d/firebase-firestore/src/main/java/com/google/firebase/firestore/remote/RemoteStore.java#L319)