Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop redirecting to non-origin sites #3710

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Stop redirecting to non-origin sites #3710

merged 2 commits into from
Sep 1, 2020

Conversation

zwu52
Copy link
Member

@zwu52 zwu52 commented Aug 31, 2020

FM should not open non-origin links.

for more context: go/fcm-security-issue

@zwu52 zwu52 requested a review from Feiyang1 August 31, 2020 23:29
@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2020

🦋 Changeset is good to go

Latest commit: 7b25e89

We got this.

This PR includes changesets to release 7 packages
Name Type
@firebase/messaging Patch
firebase Patch
@firebase/functions Patch
@firebase/rules-unit-testing Patch
@firebase/testing Patch
firebase-namespace-integration-test Patch
firebase-messaging-integration-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zwu52 zwu52 changed the title Stop directing to non-origin sites Stop redirecting to non-origin sites Aug 31, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 31, 2020

Size Analysis Report

Affected Products

No changes between base commit (caed9c0) and head commit (ff13633).

Test Logs

@zwu52 zwu52 merged commit dc98925 into master Sep 1, 2020
@zwu52 zwu52 deleted the link_security branch September 1, 2020 16:33
hsubox76 pushed a commit that referenced this pull request Sep 3, 2020
* Stop directing to non-origin sites

* Create tall-mugs-shop.md
@google-oss-bot google-oss-bot mentioned this pull request Sep 8, 2020
@firebase firebase locked and limited conversation to collaborators Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants