Throw exception when Performance custom trace API is provided with non-positive startTime or duration #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-positive startTime or duration
zijianjoy
requested review from
alikn,
Feiyang1,
hiranya911 and
hsubox76
as code owners
🦋 Changeset detectedLatest commit: 83fb206 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs
|
Size Analysis ReportAffected Products
|
| Type | Base (2be43ea) | Head (bbb735f) | Diff |
|---|---|---|---|
| size | 16.8 kB | 17.1 kB | +317 B (+1.9%) |
| size_with_ext_deps | 33.8 kB | 34.2 kB | +319 B (+0.9%) |
trace
Size
| Type | Base (2be43ea) | Head (bbb735f) | Diff |
|---|---|---|---|
| size | 16.7 kB | 17.1 kB | +317 B (+1.9%) |
| size_with_ext_deps | 33.8 kB | 34.1 kB | +319 B (+0.9%) |
Test Logs
- Base (
2be43ead): https://github.com/firebase/firebase-js-sdk/actions/runs/279535810 - Head (
bbb735ff): https://github.com/firebase/firebase-js-sdk/actions/runs/282655188
alikn
reviewed
Sep 30, 2020
Changeset File Check
|
Feiyang1
approved these changes
Oct 1, 2020
jposuna
approved these changes
Oct 1, 2020
alikn
approved these changes
Oct 2, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is common for developer to provide 0 or invalid value for
startTimeanddurationwhen callingrecord(startTime, duration, options)to create custom trace. This doesn't create error on the client side, but will be filtered silently during backend processing. Add basic validation to check developer input of both variables on the client side.