Add GMPID Header to Firestore #3888

schmidt-sebastian · 2020-10-02T21:40:42Z

No description provided.

changeset-bot · 2020-10-02T21:40:46Z

🦋 Changeset detected

Latest commit: 0a4861e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@firebase/firestore	Patch
firebase	Patch
@firebase/rules-unit-testing	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…-sdk into mrschmidt/gmpidfire

var-const · 2020-10-02T21:44:34Z

packages/firestore/src/platform/node/grpc_connection.ts

@@ -51,6 +55,7 @@ function createMetadata(databasePath: string, token: Token | null): Metadata {
      }
    }
  }
+  metadata.set('x-firebase-gmpid', appId);


Question: the plumbing accounts for the possibility of appId being empty. What do you think about not setting the header at all if appId is empty rather than setting an "empty" header?

I looked at the RTDB code and it uses an empty app ID and sends the header. I wanted to match that behavior.

var-const · 2020-10-02T21:45:51Z

packages/firestore/src/remote/rest_connection.ts

@@ -118,6 +118,7 @@ export abstract class RestConnection implements Connection {
    token: Token | null
  ): void {
    headers['X-Goog-Api-Client'] = X_GOOG_API_CLIENT_VALUE;
+    headers['X-Firebase-GMPID'] = this.databaseInfo.appId;


Nit: capitalization of the header name is different between this file and grpc_connection. Is this intentional?

The goal was to match the surrounding code. Let me fix the GRPC headers.

github-actions · 2020-10-02T21:46:00Z

Changeset File Check ✅

No modified packages are missing from the changeset file.
No changeset formatting errors detected.

google-oss-bot · 2020-10-02T21:56:50Z

Binary Size Report

Affected SDKs

`@firebase/firestore`

Type	Base (`b9087b9`)	Head (`92c093a`)	Diff
browser	249 kB	249 kB	+117 B (+0.0%)
esm2017	197 kB	197 kB	+117 B (+0.1%)
main	484 kB	484 kB	+220 B (+0.0%)
module	247 kB	247 kB	+117 B (+0.0%)
react-native	197 kB	197 kB	+117 B (+0.1%)

`@firebase/firestore/exp`

Type	Base (`b9087b9`)	Head (`92c093a`)	Diff
browser	189 kB	189 kB	+102 B (+0.1%)
main	477 kB	477 kB	+199 B (+0.0%)
module	189 kB	189 kB	+102 B (+0.1%)
react-native	189 kB	189 kB	+102 B (+0.1%)

`@firebase/firestore/lite`

Type	Base (`b9087b9`)	Head (`92c093a`)	Diff
browser	63.4 kB	63.5 kB	+75 B (+0.1%)
main	140 kB	140 kB	+107 B (+0.1%)
module	63.4 kB	63.5 kB	+75 B (+0.1%)
react-native	63.6 kB	63.7 kB	+75 B (+0.1%)

`@firebase/firestore/memory`

Type	Base (`b9087b9`)	Head (`92c093a`)	Diff
browser	187 kB	187 kB	+117 B (+0.1%)
esm2017	147 kB	147 kB	+117 B (+0.1%)
main	357 kB	357 kB	+220 B (+0.1%)
module	185 kB	185 kB	+117 B (+0.1%)
react-native	147 kB	148 kB	+117 B (+0.1%)

`firebase`

Type	Base (`b9087b9`)	Head (`92c093a`)	Diff
firebase-firestore.js	286 kB	286 kB	+117 B (+0.0%)
firebase-firestore.memory.js	226 kB	226 kB	+117 B (+0.1%)
firebase.js	829 kB	829 kB	+117 B (+0.0%)

Test Logs

Base (b9087b90): https://github.com/firebase/firebase-js-sdk/actions/runs/284181319
Head (92c093a7): https://github.com/firebase/firebase-js-sdk/actions/runs/285061435

google-oss-bot · 2020-10-02T22:01:18Z

Size Analysis Report

Affected Products

No changes between base commit (d2eda13) and head commit (d4faa7a).

Test Logs

…-sdk into mrschmidt/gmpidfire

schmidt-sebastian · 2020-10-05T22:49:27Z

This is blocked on https://critique-ng.corp.google.com/cl/335516871 (hence the failing tests)

Feiyang1 · 2021-03-23T21:41:08Z

Seems we are ready to merge this PR, since https://critique-ng.corp.google.com/cl/335516871 has been submitted?

schmidt-sebastian · 2021-03-29T19:28:28Z

We have been waiting for the CL to be rolled out, but this has now been done.

Add GMPID to Firestore

6d20b58

schmidt-sebastian requested a review from var-const October 2, 2020 21:41

schmidt-sebastian assigned var-const Oct 2, 2020

Wow there is a test

26584e3

schmidt-sebastian added the api: firestore label Oct 2, 2020

schmidt-sebastian added 2 commits October 2, 2020 14:44

Create honest-hounds-sin.md

60326a9

Merge branch 'mrschmidt/gmpidfire' of github.com:firebase/firebase-js…

ff28db5

…-sdk into mrschmidt/gmpidfire

var-const reviewed Oct 2, 2020

View reviewed changes

Update honest-hounds-sin.md

20b5598

schmidt-sebastian added 2 commits October 2, 2020 15:09

Snakecase

02d6f43

Merge branch 'mrschmidt/gmpidfire' of github.com:firebase/firebase-js…

9a2033a

…-sdk into mrschmidt/gmpidfire

var-const approved these changes Oct 2, 2020

View reviewed changes

var-const assigned schmidt-sebastian and unassigned var-const Oct 2, 2020

schmidt-sebastian added 6 commits November 17, 2020 19:14

Merge

c58a14b

Fix build

2addf3d

Comment fix

d4d5615

Merge

9dd1d6d

Merge branch 'master' into mrschmidt/gmpidfire

3b923f9

Merge

d448d5b

schmidt-sebastian requested review from Feiyang1, hiranya911 and hsubox76 as code owners January 20, 2021 02:41

Merge branch 'master' into mrschmidt/gmpidfire

0a4861e

schmidt-sebastian merged commit 4cb0945 into master Mar 30, 2021

schmidt-sebastian deleted the mrschmidt/gmpidfire branch March 30, 2021 17:04

google-oss-bot mentioned this pull request Mar 30, 2021

Version Packages #4690

Merged

firebase locked and limited conversation to collaborators Apr 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GMPID Header to Firestore #3888

Add GMPID Header to Firestore #3888

schmidt-sebastian commented Oct 2, 2020

changeset-bot bot commented Oct 2, 2020 •

edited

var-const Oct 2, 2020

schmidt-sebastian Oct 2, 2020

var-const Oct 2, 2020

schmidt-sebastian Oct 2, 2020

github-actions bot commented Oct 2, 2020 •

edited

google-oss-bot commented Oct 2, 2020 •

edited

`@firebase/firestore`

`@firebase/firestore/exp`

`@firebase/firestore/lite`

`@firebase/firestore/memory`

`firebase`

google-oss-bot commented Oct 2, 2020 •

edited

Affected Products

Test Logs

schmidt-sebastian commented Oct 5, 2020

Feiyang1 commented Mar 23, 2021 •

edited

schmidt-sebastian commented Mar 29, 2021

Add GMPID Header to Firestore #3888

Add GMPID Header to Firestore #3888

Conversation

schmidt-sebastian commented Oct 2, 2020

changeset-bot bot commented Oct 2, 2020 • edited

🦋 Changeset detected

var-const Oct 2, 2020

Choose a reason for hiding this comment

schmidt-sebastian Oct 2, 2020

Choose a reason for hiding this comment

var-const Oct 2, 2020

Choose a reason for hiding this comment

schmidt-sebastian Oct 2, 2020

Choose a reason for hiding this comment

github-actions bot commented Oct 2, 2020 • edited

Changeset File Check ✅

google-oss-bot commented Oct 2, 2020 • edited

Binary Size Report

Affected SDKs

@firebase/firestore

@firebase/firestore/exp

@firebase/firestore/lite

@firebase/firestore/memory

firebase

Test Logs

google-oss-bot commented Oct 2, 2020 • edited

Size Analysis Report

Affected Products

Test Logs

schmidt-sebastian commented Oct 5, 2020

Feiyang1 commented Mar 23, 2021 • edited

schmidt-sebastian commented Mar 29, 2021

changeset-bot bot commented Oct 2, 2020 •

edited

github-actions bot commented Oct 2, 2020 •

edited

google-oss-bot commented Oct 2, 2020 •

edited

`@firebase/firestore`

`@firebase/firestore/exp`

`@firebase/firestore/lite`

`@firebase/firestore/memory`

`firebase`

google-oss-bot commented Oct 2, 2020 •

edited

Feiyang1 commented Mar 23, 2021 •

edited