Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom claims #3915

Merged
merged 1 commit into from Oct 9, 2020
Merged

Fix custom claims #3915

merged 1 commit into from Oct 9, 2020

Conversation

samtstern
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

See #3876 (comment)

Testing

  • New unit tests

API Changes

  • Reverting a bug

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2020

🦋 Changeset detected

Latest commit: bc49a69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@samtstern
Copy link
Contributor Author

cc @mdirolf

@yuchenshi
Copy link
Member

yuchenshi commented Oct 9, 2020

Well actually... Shouldn't we use intersection like MyInterface & {[claim: string]: any} instead? Let's see which one works better

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (4f997bc) and head commit (ac4c434).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (4f997bc) and head commit (ac4c434).

Test Logs

@samtstern samtstern merged commit fe0ae19 into master Oct 9, 2020
@google-oss-bot google-oss-bot mentioned this pull request Oct 13, 2020
@firebase firebase locked and limited conversation to collaborators Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants