Remove JS input validation for Storage #3967
Conversation
|
Binary Size ReportAffected SDKs
Test Logs
|
Size Analysis ReportAffected ProductsNo changes between base commit (a5768b0) and head commit (6dbbe61). Test Logs
|
…/firebase-js-sdk into mrschmidt/no-validation-storage
| if (!type.isObject(p) || !p) { | ||
| throw 'Expected Metadata object.'; | ||
| } | ||
| export function validateMetadata(p: { [key: string]: unknown }): void { |
There was a problem hiding this comment.
I actually got rid of this entirely in storage-exp because it's checking types of Metadata fields which should be caught by typescript check? Or did I make a mistake?
There was a problem hiding this comment.
Oh, I didn't realize this was fully typed. Removed.
packages/storage/src/reference.ts
Outdated
| @@ -353,3 +338,23 @@ export class Reference { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| export function validateNumber( | |||
There was a problem hiding this comment.
Should this go in a separate file? type.ts?
There was a problem hiding this comment.
I didn't want to keep the original file for just this one function, but types.ts is a good location. Moved.
|
wow, impressive 10% saving! |
Removes all input validation that can be caught by TypeScript transpiler.