Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export public types from functions-exp #4342

Merged
merged 3 commits into from
Jan 26, 2021
Merged

Export public types from functions-exp #4342

merged 3 commits into from
Jan 26, 2021

Conversation

hsubox76
Copy link
Contributor

Export public types. Reviewed functions-types and seems like they all should be public.

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2225bef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 26, 2021 •
edited
Loading

Size Analysis Report

Affected Products

  • @firebase/analytics-exp

    • getAnalytics

      Size Table

      TypeBase (4190745)Head (df6e1a2)Diff
      size
      8.98 kB
      9.01 kB
      +36 B (+0.4%)
      size-with-ext-deps
      14.2 kB
      26.3 kB
      +12.1 kB (+84.8%)

    • isSupported

      Size Table

      TypeBase (4190745)Head (df6e1a2)Diff
      size
      9.03 kB
      9.07 kB
      +36 B (+0.4%)
      size-with-ext-deps
      14.3 kB
      26.4 kB
      +12.1 kB (+85.0%)

    • logEvent

      Size Table

      TypeBase (4190745)Head (df6e1a2)Diff
      size
      8.89 kB
      8.93 kB
      +36 B (+0.4%)
      size-with-ext-deps
      14.1 kB
      26.3 kB
      +12.1 kB (+85.9%)

    • setAnalyticsCollectionEnabled

      Size Table

      TypeBase (4190745)Head (df6e1a2)Diff
      size
      9.05 kB
      9.08 kB
      +36 B (+0.4%)
      size-with-ext-deps
      14.3 kB
      26.4 kB
      +12.1 kB (+84.9%)

    • setCurrentScreen

      Size Table

      TypeBase (4190745)Head (df6e1a2)Diff
      size
      9.13 kB
      9.17 kB
      +36 B (+0.4%)
      size-with-ext-deps
      14.4 kB
      26.5 kB
      +12.1 kB (+84.4%)

    • setUserId

      Size Table

      TypeBase (4190745)Head (df6e1a2)Diff
      size
      9.12 kB
      9.15 kB
      +36 B (+0.4%)
      size-with-ext-deps
      14.4 kB
      26.5 kB
      +12.1 kB (+84.5%)

    • setUserProperties

      Size Table

      TypeBase (4190745)Head (df6e1a2)Diff
      size
      9.19 kB
      9.23 kB
      +36 B (+0.4%)
      size-with-ext-deps
      14.4 kB
      26.6 kB
      +12.1 kB (+84.0%)

    • settings

      Size Table

      TypeBase (4190745)Head (df6e1a2)Diff
      size
      9.02 kB
      9.05 kB
      +36 B (+0.4%)
      size-with-ext-deps
      14.3 kB
      26.4 kB
      +12.1 kB (+85.1%)

@hsubox76 hsubox76 merged commit c2bd3db into master Jan 26, 2021
@hsubox76 hsubox76 deleted the ch-functions-types branch January 26, 2021 01:45
@firebase firebase locked and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hsubox76 @google-oss-bot @Feiyang1