Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movie client-side popup origin validation to _after_ popup is opened #4514

Merged
merged 2 commits into from
Feb 24, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Feb 23, 2021

Popups should open as quickly as possible after being triggered by a user action. This change moves the origin validation stage to after the popup is opened, to prevent latency between user action and the popup. See this discussion: #4432

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 23, 2021

Binary Size Report

Affected SDKs

No changes between base commit (39a8be6) and head commit (173e52a).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

  • @firebase/auth-exp

    • getAuth

      Size Table

      TypeBase (08e2aa3)Head (2fdd85e)Diff
      size
      55.6 kB
      55.6 kB
      -29 B (-0.1%)
      size-with-ext-deps
      66.6 kB
      66.6 kB
      -29 B (-0.0%)
    • linkWithPopup

      Size Table

      TypeBase (08e2aa3)Head (2fdd85e)Diff
      size
      36.9 kB
      37.0 kB
      +72 B (+0.2%)
      size-with-ext-deps
      47.6 kB
      47.7 kB
      +72 B (+0.2%)
    • reauthenticateWithPopup

      Size Table

      TypeBase (08e2aa3)Head (2fdd85e)Diff
      size
      36.9 kB
      37.0 kB
      +72 B (+0.2%)
      size-with-ext-deps
      47.6 kB
      47.7 kB
      +72 B (+0.2%)
    • signInWithPopup

      Size Table

      TypeBase (08e2aa3)Head (2fdd85e)Diff
      size
      36.9 kB
      37.0 kB
      +72 B (+0.2%)
      size-with-ext-deps
      47.6 kB
      47.7 kB
      +72 B (+0.2%)
    • browserPopupRedirectResolver

      Size Table

      TypeBase (08e2aa3)Head (2fdd85e)Diff
      size
      45.3 kB
      45.3 kB
      -29 B (-0.1%)
      size-with-ext-deps
      56.2 kB
      56.1 kB
      -29 B (-0.1%)

@sam-gc sam-gc merged commit bc9f841 into master Feb 24, 2021
@sam-gc sam-gc deleted the samgho/origin_validation branch February 24, 2021 01:45
@firebase firebase locked and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants