Add default converter option in withConverter() #4577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 45aba16 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs
|
Size Analysis Report |
schmidt-sebastian
approved these changes
Mar 3, 2021
| ): PublicDocumentReference<U>; | ||
| withConverter<U>( | ||
| converter: PublicFirestoreDataConverter<U> | null | ||
| ): PublicDocumentReference<U> | PublicDocumentReference<PublicDocumentData> { |
There was a problem hiding this comment.
In Node, this is just PublicDocumentReference<U> and TypeScript deduces U.
| withConverter<U>(converter: PublicFirestoreDataConverter<U>): Query<U>; | ||
| withConverter<U>( | ||
| converter: PublicFirestoreDataConverter<U> | null | ||
| ): Query<U> | Query<DocumentData> { |
| ): CollectionReference<U>; | ||
| withConverter<U>( | ||
| converter: PublicFirestoreDataConverter<U> | null | ||
| ): CollectionReference<U> | CollectionReference<PublicDocumentData> { |
There was a problem hiding this comment.
And one more for old times sake.
Feiyang1
approved these changes
Mar 8, 2021
Merged
This was referenced Mar 11, 2021
This was referenced Mar 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting from node.