Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auth compat] Fix the way we initialize compat auth. Also fix some broken integration tests #4653

Merged
merged 5 commits into from
Mar 22, 2021
Merged

[Auth compat] Fix the way we initialize compat auth. Also fix some broken integration tests #4653

merged 5 commits into from
Mar 22, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Mar 18, 2021

No description provided.

@sam-gc sam-gc requested a review from yuchenshi March 18, 2021 23:36
@sam-gc sam-gc requested a review from avolkovi as a code owner March 18, 2021 23:36
@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2021 •
edited

⚠️ No Changeset found

Latest commit: ef61527

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 19, 2021 •
edited

Size Analysis Report

Affected Products

No changes between base commit (1db2c3a) and head commit (6d6d361).

@yuchenshi yuchenshi assigned sam-gc and unassigned yuchenshi Mar 20, 2021
@sam-gc sam-gc merged commit fdadf71 into master Mar 22, 2021
@sam-gc sam-gc deleted the samgho/compat-persistence branch March 22, 2021 22:21
@firebase firebase locked and limited conversation to collaborators Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

Assignees

@sam-gc sam-gc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sam-gc @google-oss-bot @yuchenshi