Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove floating point rounding error in Timestamp.fromMillis() #4745

Merged
merged 4 commits into from
Apr 8, 2021

Conversation

thebrianchen
Copy link

Porting over from node.

@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2021

🦋 Changeset detected

Latest commit: 7ebc1a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 7, 2021

Size Analysis Report

Affected Products

Diffs between base commit (f24d896) and head commit (6b2d8c8) are too large (178,998 characters) to display.

Please check below links to see details from the original test log.

@thebrianchen thebrianchen merged commit 6db185b into master Apr 8, 2021
@thebrianchen thebrianchen deleted the bc/timestamp branch April 8, 2021 15:46
@google-oss-bot google-oss-bot mentioned this pull request Apr 12, 2021
@firebase firebase locked and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants