Use 'pagehide' for page termination by default. #4886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f5584da The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/firestore/src/util/types.ts
Outdated
| * if available, it falls back to the less reliable 'unload'. | ||
| */ | ||
| export function terminationEvent(window: WindowLike | null): string { | ||
| return 'onpagehide' in window! ? 'pagehide' : 'unload'; |
There was a problem hiding this comment.
I think you can just use "pagehide" and do not need to fall back: https://caniuse.com/page-transition-events
schmidt-sebastian
approved these changes
May 11, 2021
…ebase-js-sdk into wuandy/WiserPageTermination
Merged
0xdevalias
reviewed
Jun 5, 2021
| @@ -58,7 +58,7 @@ export class FakeWindow implements WindowLike { | |||
| case 'storage': | |||
| this.storageListeners.push(listener); | |||
| break; | |||
| case 'unload': | |||
| case 'pagehide': | |||
| case 'visibilitychange': | |||
| // The spec tests currently do not rely on `unload`/`visibilitychange` | |||
There was a problem hiding this comment.
[nit] Looks like this comment refers to the old ‘unload’ rather than ‘pagehide’
There was a problem hiding this comment.
Thanks for catching this. WIll fix soon.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #4236
See: https://developers.google.com/web/updates/2018/07/page-lifecycle-api#legacy-lifecycle-apis-to-avoid