Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NodeJS support to Storage V8 #5149

Merged
merged 4 commits into from
Jul 14, 2021
Merged

Add NodeJS support to Storage V8 #5149

merged 4 commits into from
Jul 14, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

This adds NodeJS support to the current Storage release.

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2021

⚠️ No Changeset found

Latest commit: 17b38f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2021 •
edited

Changeset File Check ⚠️

  • Changeset formatting error in following file:

    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Error: could not parse changeset - invalid frontmatter: ---
@firebase/storage: minor
---

Add NodeJS support to Cloud Storage for Firebase. This release changes the `main` field in package.json to point to a Node specific build. If you are building a bundle for borwser usage, please make sure that your bundler uses the `browser` field (the default).

    at Object.parseChangesetFile [as default] (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/parse/dist/parse.cjs.dev.js:35:11)
    at /home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/read/dist/read.cjs.dev.js:137:71
    at async Promise.all (index 0)
    at async Object.getChangesets [as default] (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/read/dist/read.cjs.dev.js:141:48)
    at async Object.getReleasePlan [as default] (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/get-release-plan/dist/get-release-plan.cjs.dev.js:70:22)
    at async getStatus (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:972:23)
    at async run$1 (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:1227:11)

  • Package @firebase/storage has a minor bump which requires an additional line to bump the main "firebase" package to minor.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 14, 2021 •
edited

Binary Size Report

Affected SDKs

  • @firebase/analytics

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    esm2017 ? 18.7 kB ? (?)
    main ? 24.2 kB ? (?)
    module ? 23.4 kB ? (?)

  • @firebase/api-documenter

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    main ? 3.72 kB ? (?)

  • @firebase/app

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 11.0 kB ? (?)
    esm2017 ? 9.80 kB ? (?)
    lite ? 8.93 kB ? (?)
    lite-esm2017 ? 7.93 kB ? (?)
    main ? 10.1 kB ? (?)
    module ? 11.0 kB ? (?)
    react-native ? 9.86 kB ? (?)

  • @firebase/app-check

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 22.5 kB ? (?)
    esm2017 ? 18.7 kB ? (?)
    main ? 22.5 kB ? (?)
    module ? 22.1 kB ? (?)

  • @firebase/auth

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 181 kB ? (?)
    main ? 181 kB ? (?)
    module ? 181 kB ? (?)

  • @firebase/component

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 8.33 kB ? (?)
    esm2017 ? 6.32 kB ? (?)
    main ? 8.67 kB ? (?)
    module ? 8.33 kB ? (?)

  • @firebase/database

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 296 kB ? (?)
    esm2017 ? 265 kB ? (?)
    main ? 299 kB ? (?)
    module ? 296 kB ? (?)

  • @firebase/database-compat

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 86.5 kB ? (?)
    main ? 103 kB ? (?)
    module ? 86.5 kB ? (?)

  • @firebase/database-exp

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 246 kB ? (?)
    main ? 278 kB ? (?)
    module ? 246 kB ? (?)

  • @firebase/firestore

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 284 kB ? (?)
    esm2017 ? 226 kB ? (?)
    main ? 531 kB ? (?)
    module ? 284 kB ? (?)
    react-native ? 226 kB ? (?)

  • @firebase/firestore-compat

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 29.0 kB ? (?)
    main ? 38.1 kB ? (?)
    module ? 29.0 kB ? (?)
    react-native ? 28.7 kB ? (?)

  • @firebase/firestore-exp

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 224 kB ? (?)
    main ? 510 kB ? (?)
    module ? 224 kB ? (?)
    react-native ? 224 kB ? (?)

  • @firebase/firestore-lite

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 72.5 kB ? (?)
    main ? 149 kB ? (?)
    module ? 72.5 kB ? (?)
    react-native ? 72.8 kB ? (?)

  • @firebase/firestore/bundle

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 290 kB ? (?)
    esm2017 ? 177 kB ? (?)
    main ? 527 kB ? (?)
    module ? 290 kB ? (?)
    react-native ? 177 kB ? (?)

  • @firebase/firestore/memory

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 216 kB ? (?)
    esm2017 ? 172 kB ? (?)
    main ? 325 kB ? (?)
    module ? 216 kB ? (?)
    react-native ? 172 kB ? (?)

  • @firebase/firestore/memory-bundle

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 224 kB ? (?)
    esm2017 ? 177 kB ? (?)
    main ? 322 kB ? (?)
    module ? 224 kB ? (?)
    react-native ? 177 kB ? (?)

  • @firebase/functions

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 10.7 kB ? (?)
    esm2017 ? 8.21 kB ? (?)
    main ? 11.1 kB ? (?)
    module ? 10.7 kB ? (?)

  • @firebase/installations

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    esm2017 ? 16.6 kB ? (?)
    main ? 22.2 kB ? (?)
    module ? 21.6 kB ? (?)

  • @firebase/logger

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    esm2017 ? 3.25 kB ? (?)
    main ? 5.40 kB ? (?)
    module ? 4.65 kB ? (?)

  • @firebase/messaging

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    esm2017 ? 26.2 kB ? (?)
    main ? 34.9 kB ? (?)
    module ? 34.4 kB ? (?)

  • @firebase/performance

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 27.7 kB ? (?)
    esm2017 ? 25.9 kB ? (?)
    main ? 28.0 kB ? (?)
    module ? 27.7 kB ? (?)

  • @firebase/polyfill

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    main ? 747 B ? (?)
    module ? 705 B ? (?)

  • @firebase/remote-config

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 22.4 kB ? (?)
    esm2017 ? 17.4 kB ? (?)
    main ? 23.0 kB ? (?)
    module ? 22.4 kB ? (?)

  • @firebase/rules-unit-testing

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    main ? 15.3 kB ? (?)

  • @firebase/storage

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 63.7 kB ? (?)
    esm2017 ? 54.9 kB ? (?)
    main ? 55.4 kB ? (?)
    module ? 63.7 kB ? (?)

  • @firebase/storage-compat

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 10.3 kB ? (?)
    main ? 29.3 kB ? (?)
    module ? 10.3 kB ? (?)

  • @firebase/storage-exp

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 51.6 kB ? (?)
    main ? 53.0 kB ? (?)
    module ? 51.6 kB ? (?)

  • @firebase/util

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    browser ? 21.2 kB ? (?)
    esm2017 ? 19.9 kB ? (?)
    main ? 25.8 kB ? (?)
    module ? 21.2 kB ? (?)

  • @firebase/webchannel-wrapper

    Type Base (cca8d4b) Head (dd8bdcf) Diff
    esm2017 ? 43.2 kB ? (?)
    main ? 50.7 kB ? (?)
    module ? 44.8 kB ? (?)

  • firebase

    Click to show 16 binary size changes.
    Type Base (cca8d4b) Head (dd8bdcf) Diff
    firebase-analytics.js ? 35.7 kB ? (?)
    firebase-app-check.js ? 22.8 kB ? (?)
    firebase-app.js ? 21.9 kB ? (?)
    firebase-auth.js ? 177 kB ? (?)
    firebase-database.js ? 187 kB ? (?)
    firebase-firestore.js ? 336 kB ? (?)
    firebase-firestore.memory.js ? 271 kB ? (?)
    firebase-functions.js ? 10.9 kB ? (?)
    firebase-installations.js ? 19.3 kB ? (?)
    firebase-messaging.js ? 40.9 kB ? (?)
    firebase-performance-standalone.es2017.js ? 73.4 kB ? (?)
    firebase-performance-standalone.js ? 49.8 kB ? (?)
    firebase-performance.js ? 38.3 kB ? (?)
    firebase-remote-config.js ? 36.9 kB ? (?)
    firebase-storage.js ? 41.6 kB ? (?)
    firebase.js ? 893 kB ? (?)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 14, 2021 •
edited

Size Analysis Report

Affected Products

No changes between base commit (cca8d4b) and head commit (dd8bdcf).

@schmidt-sebastian schmidt-sebastian merged commit b3caa51 into master Jul 14, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/nodejs branch July 14, 2021 19:57
@Feiyang1
Copy link
Member

addresses #18

@hsubox76 hsubox76 mentioned this pull request Jul 20, 2021
Merged
@google-oss-bot google-oss-bot mentioned this pull request Jul 20, 2021
Merged
@hsubox76 hsubox76 mentioned this pull request Jul 29, 2021
Merged
@yuchenshi yuchenshi mentioned this pull request Aug 4, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schmidt-sebastian @google-oss-bot @Feiyang1