Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip IndexedDB cleanup on Safari 14 #5166

Merged
merged 4 commits into from
Jul 19, 2021
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jul 16, 2021

This PR changes our IndexedDB shutdown to skip all remaining work items on Safari 14. It is believed that writing to IndexedDB during unload can trigger a bug on Safari that prevents IndexedDB from loading during the next page load.

Fixes #4076

This PR changes our IndexedDB shutdown to skip all remaining work items on Safari 14. It is believed that writing to IndexedDB during unload can trigger a bug on Safari that prevents IndexedDB from loading during the next page load.
@changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2021

🦋 Changeset detected

Latest commit: 3663f6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2021

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 16, 2021

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (02586c9) Head (28de885) Diff
    browser 284 kB 285 kB +240 B (+0.1%)
    esm2017 226 kB 227 kB +252 B (+0.1%)
    main 531 kB 531 kB +424 B (+0.1%)
    module 284 kB 285 kB +240 B (+0.1%)
    react-native 227 kB 227 kB +256 B (+0.1%)
  • @firebase/firestore-exp

    Type Base (02586c9) Head (28de885) Diff
    browser 224 kB 224 kB +251 B (+0.1%)
    main 510 kB 511 kB +424 B (+0.1%)
    module 224 kB 224 kB +251 B (+0.1%)
    react-native 224 kB 224 kB +281 B (+0.1%)
  • @firebase/firestore-lite

    Type Base (02586c9) Head (28de885) Diff
    browser 72.6 kB 72.7 kB +153 B (+0.2%)
    main 149 kB 149 kB +324 B (+0.2%)
    module 72.6 kB 72.7 kB +153 B (+0.2%)
    react-native 72.8 kB 72.9 kB +153 B (+0.2%)
  • @firebase/firestore/bundle

    Type Base (02586c9) Head (28de885) Diff
    browser 290 kB 291 kB +286 B (+0.1%)
    esm2017 177 kB 177 kB +157 B (+0.1%)
    main 527 kB 527 kB +424 B (+0.1%)
    module 290 kB 291 kB +286 B (+0.1%)
    react-native 177 kB 177 kB +161 B (+0.1%)
  • @firebase/firestore/memory

    Type Base (02586c9) Head (28de885) Diff
    browser 216 kB 217 kB +457 B (+0.2%)
    esm2017 172 kB 172 kB +157 B (+0.1%)
    main 325 kB 325 kB +290 B (+0.1%)
    module 216 kB 217 kB +457 B (+0.2%)
    react-native 172 kB 172 kB +161 B (+0.1%)
  • @firebase/firestore/memory-bundle

    Type Base (02586c9) Head (28de885) Diff
    browser 224 kB 225 kB +185 B (+0.1%)
    esm2017 177 kB 177 kB +157 B (+0.1%)
    main 322 kB 322 kB +290 B (+0.1%)
    module 224 kB 225 kB +185 B (+0.1%)
    react-native 177 kB 177 kB +161 B (+0.1%)
  • firebase

    Type Base (02586c9) Head (28de885) Diff
    firebase-firestore.js 336 kB 336 kB +465 B (+0.1%)
    firebase-firestore.memory.js 271 kB 271 kB +175 B (+0.1%)
    firebase.js 893 kB 894 kB +339 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 16, 2021

Size Analysis Report

Affected Products

No changes between base commit (02586c9) and head commit (28de885).

@schmidt-sebastian schmidt-sebastian merged commit b51be1d into master Jul 19, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/abruptshutdown branch July 19, 2021 18:06
@google-oss-bot google-oss-bot mentioned this pull request Jul 20, 2021
@Feiyang1
Copy link
Member

oh no, Safari again.

@firebase firebase locked and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enablePersistence not working on Safari v14
4 participants